Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce totp command for OTP token #975

Merged
merged 4 commits into from
Oct 28, 2024
Merged

feat: introduce totp command for OTP token #975

merged 4 commits into from
Oct 28, 2024

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Oct 25, 2024 •
edited
Loading 

npx @elastic/synthetics totp secret --issuer <issuer> --label <label>

// prints
OTP Token: 123456

Documentation will be covered as part of elastic/observability-docs#4334

emilioalvap
emilioalvap reviewed Oct 28, 2024
View reviewed changes
src/cli.ts Outdated Show resolved Hide resolved
emilioalvap
emilioalvap previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM

vigneshshanmugam and others added 2 commits October 28, 2024 08:23
@vigneshshanmugam
Merge branch 'main' into totp-cmd
1e73b36
@vigneshshanmugam @emilioalvap
print error
00a98a8 
Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
emilioalvap
emilioalvap approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit 79fe27d into elastic:main Oct 28, 2024
8 checks passed
@vigneshshanmugam vigneshshanmugam deleted the totp-cmd branch October 28, 2024 19:44
@vigneshshanmugam vigneshshanmugam mentioned this pull request Oct 28, 2024
Merged
10 tasks
This was referenced Nov 4, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

@shahzad31 shahzad31 Awaiting requested review from shahzad31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vigneshshanmugam @emilioalvap